Re: [PATCH v7 22/22] x86/virt/seamldr: Log TDX module update failures
From: Chao Gao
Date: Tue Apr 14 2026 - 06:37:37 EST
On Tue, Apr 14, 2026 at 04:04:05AM +0800, Edgecombe, Rick P wrote:
>On Tue, 2026-03-31 at 05:41 -0700, Chao Gao wrote:
>> Currently, there is no way to restore a TDX module from shutdown state to
>> running state. This means if errors occur after a successful module
>> shutdown, they are unrecoverable since the old module is gone but the new
>> module isn't installed. All subsequent SEAMCALLs to the TDX module will
>> fail, so TDs will be killed due to SEAMCALL failures.
>>
>> Log a message to clarify that SEAMCALL errors are expected in this
>> scenario. This ensures that after update failures, the first message in
>> dmesg explains the situation rather than showing confusing call traces from
>> various code paths.
>
>Why is this patch at the end? Is it not valid initial behavior?
It's not strictly required for the update to function. It just improves
debuggability by explaining expected SEAMCALL errors after a failure.
I placed it last so maintainers can easily drop it if they consider it
non-essential, similar to the guidance in *.
*: https://lore.kernel.org/kvm/63082cd1-15ab-4aaf-83ad-f72d94b9bb8e@xxxxxxxxx/