Re: [PATCH 4/6] clk: qcom: gxclkctl: Remove GX/GMxC rail votes to align with IFPC
From: Konrad Dybcio
Date: Tue Apr 14 2026 - 10:48:20 EST
On 4/8/26 9:25 AM, Taniya Das wrote:
>
>
> On 4/7/2026 4:59 PM, Konrad Dybcio wrote:
>>>
>>> #include <dt-bindings/clock/qcom,kaanapali-gxclkctl.h> @@ -61,7
>>> +62,15 @@ MODULE_DEVICE_TABLE(of,
>>> gx_clkctl_kaanapali_match_table);
>>>
>>> static int gx_clkctl_kaanapali_probe(struct platform_device *pdev)
>>> { - return qcom_cc_probe(pdev, &gx_clkctl_kaanapali_desc); + int
>>> ret; + + ret = qcom_cc_probe(pdev, &gx_clkctl_kaanapali_desc); +
>>> if (ret) + return ret; + + pm_runtime_disable(&pdev->dev);
>> My understanding is that this works because we have more than one
>> domain associated with the nod (so the generic code that would
>> otherwise enable a single one so long as the device is resumed
>> doesn't apply) and your previous patch ensures that after probe, the
>> clock controller is being put to sleep, right before
>> pm_runtime_disable() executes.
>
> Konrad, by disabling runtime_pm will ensure that when GMU is moved to
> runtime active the clock controller is not runtime resumed, which would
> prevent the votes on the rails as per IFPC expectations.
Right, so the burden of only accessing the gxclkctl when it's got
power gets moved to the driver (which patch 6 assures), got it.
Konrad