Re: [PATCH 03/11] media: iris: Add context bank hooks for platform specific initialization

From: Dmitry Baryshkov

Date: Tue Apr 14 2026 - 11:22:16 EST


On Tue, Apr 14, 2026 at 10:29:59AM +0530, Vishnu Reddy wrote:
> Add init and deinit hooks in the platform data for context bank setup.
> These hooks allow platform specific code to initialize and tear down
> context banks.
>
> The Glymur platform requires a dedicated firmware context bank device
> which is mapped to the firmware stream ID to load the firmware.

Change the order of paragraphs. You should start with the definition of
the problem rather than putting the cart before the horse and starting
from the solution.

>
> Signed-off-by: Vishnu Reddy <busanna.reddy@xxxxxxxxxxxxxxxx>
> ---
> .../platform/qcom/iris/iris_platform_common.h | 2 ++
> drivers/media/platform/qcom/iris/iris_probe.c | 23 +++++++++++++++++++++-
> 2 files changed, 24 insertions(+), 1 deletion(-)
>

--
With best wishes
Dmitry