Re: [PATCH 1/2] hwtracing: hisi_ptt: Propagate DMA reset timeout in trace_start()

[Pradhan, Sanman]

From: Sanman Pradhan <psanman@xxxxxxxxxxx>

On 2026/4/14, Yicong Yang wrote:
> the other status wait functions in this driver return a boolean, it's better to keep consistence.

Good point. Will switch hisi_ptt_wait_dma_reset_done() to return bool,
matching hisi_ptt_wait_trace_hw_idle() and hisi_ptt_wait_tuning_finish().

> could add some error log here for better debug. otherwise looks good to me.

Will add a pci_err() on the timeout path.

> the timeout wasn't checked since the hardware reset will be finished in the limited time normally,
> which is less than the HISI_PTT_RESET_TIMEOUT_US. It'll be better to add this check in case
> there's something wrong with the device.

Agreed. v2 will address both comments.

Thank you, for the review.

Thank you.

Regards,
Sanman Pradhan