Re: [PATCH V1] accel/amdxdna: Fix fatal_error_info layout in firmware interface

[Mario Limonciello]

On 4/14/26 11:56, Lizhi Hou wrote:
> From: Max Zhen <max.zhen@xxxxxxx>
>
> Adjust struct fatal_error_info to match the expected driver/firmware
> interface layout.
>
> The structure is used to retrieve debug information from firmware when
> a command becomes stuck on the device. The reserved field currently
> uses 128 u32 entries, which makes the structure larger than intended
> and causes the layout to no longer match the firmware definition.
>
> Reduce the reserved array size from 128 to 127 entries so the
> structure matches the expected interface format.
>
> Fixes: 25854131c04a ("accel/amdxdna: Support retrieving hardware context debug information")
> Signed-off-by: Max Zhen <max.zhen@xxxxxxx>
> Signed-off-by: Lizhi Hou <lizhi.hou@xxxxxxx>
Reviewed-by: Mario Limonciello (AMD) <superm1@xxxxxxxxxx>

> ---
>   drivers/accel/amdxdna/aie2_msg_priv.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/amdxdna/aie2_msg_priv.h b/drivers/accel/amdxdna/aie2_msg_priv.h
> index fc2e99510980..b10552c627ee 100644
> --- a/drivers/accel/amdxdna/aie2_msg_priv.h
> +++ b/drivers/accel/amdxdna/aie2_msg_priv.h
> @@ -461,7 +461,7 @@ struct fatal_error_info {
>   	__u32 exception_pc;       /* Program Counter at the time of the exception */
>   	__u32 app_module;         /* Error module name */
>   	__u32 task_index;         /* Index of the task in which the error occurred */
> -	__u32 reserved[128];
> +	__u32 reserved[127];
>   };
>   
>   struct app_health_report {