Re: [PATCH v7 07/22] coco/tdx-host: Implement firmware upload sysfs ABI for TDX module updates

From: Edgecombe, Rick P

Date: Tue Apr 14 2026 - 13:04:51 EST


On Tue, 2026-04-14 at 17:50 +0800, Chao Gao wrote:
> > It's hard to review whether these error codes match because the function
> > doesn't
> > return them yet. Why isn't this patch just done later in the series after
> > everything is in place?
>
> Good point.
>
> The series is ordered top-down (user interface first, implementation details
> later). I could either move this patch later, or add each error mapping in the
> patch that introduces the corresponding return value. I'd prefer the latter to
> keep the top-down ordering. Would that work for you?

Either way sounds ok to me.