Re: [PATCH v2] cxl/region: Validate partition index before array access
From: Alison Schofield
Date: Tue Apr 14 2026 - 13:05:24 EST
On Tue, Apr 14, 2026 at 11:14:10PM +0800, KobaK wrote:
> On Mon, 13 Apr 2026 21:37:33 -0700, Alison Schofield wrote:
> > > Fixes: be5cbd084027 ("cxl: Kill enum cxl_decoder_mode")
> >
> > The above tag added the check for part < 0 in construct_region(),
> > so that's not the fixes tag. Like I wrote in v1, I don't see the
> > obvious tag that deleted that check, else I'd just tell you.
>
> The check was lost during a merge resolution, not by any single
> non-merge commit. How about dropping the Fixes tag entirely and
> explaining in the body instead?
Appreciate your follow-up Koba but a v3 is needless churn at
this point. DaveJ can fix up or drop the tag upon merging.
Note to DaveJ: see the v1 thread.
>
> > > Signed-off-by: Koba Ko <kobak@xxxxxxxxxx>
> > > ---
> >
> > Need a changelog here.
> > See https://docs.kernel.org/process/submitting-patches.html#commentary
>
> Sorry, missed it. Will add in v3.
No need to v3. Just a note for next time.
>
> - Koba