Re: [PATCH v7 10/22] x86/virt/seamldr: Abort updates if errors occurred midway

From: Edgecombe, Rick P

Date: Tue Apr 14 2026 - 13:43:37 EST


On Tue, 2026-04-14 at 17:59 +0800, Chao Gao wrote:
> The main point is correctness, not saving time.
>
> If shutdown fails midway, the update is still recoverable — TDs can continue
> running. But if we proceed to seamldr.install anyway, it becomes destructive.
> Aborting early on shutdown failure preserves recoverability (this is needed to
> handle races between updates and TD build/migration).
>
> If seamldr.install itself fails, it's already destructive, so aborting early
> there just saves time. But using the same abort mechanism for both keeps the
> error handling uniform.

If it's non-required for "turning the lights on" it seems aligned with Dave's
suggestion you highlighted to drop it from the series.