[PATCH v6 6/7] iio: ssp_sensors: Use dev_err_probe

[Sanjay Chitroda]

From: Sanjay Chitroda <sanjayembeddedse@xxxxxxxxx>

dev_err_probe() makes error code handling simpler and handle
deferred probe nicely (avoid spamming logs).

Signed-off-by: Sanjay Chitroda <sanjayembeddedse@xxxxxxxxx>
---
 drivers/iio/common/ssp_sensors/ssp_dev.c | 36 ++++++++++--------------
 1 file changed, 15 insertions(+), 21 deletions(-)

diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c
index 94ecc794f926..0a00ead3195d 100644
--- a/drivers/iio/common/ssp_sensors/ssp_dev.c
+++ b/drivers/iio/common/ssp_sensors/ssp_dev.c
@@ -496,25 +496,21 @@ static int ssp_probe(struct spi_device *spi)
 	struct ssp_data *data;
 
 	data = ssp_parse_dt(&spi->dev);
-	if (!data) {
-		dev_err(&spi->dev, "Failed to find platform data\n");
-		return -ENODEV;
-	}
+	if (!data)
+		return dev_err_probe(&spi->dev, -ENODEV,
+				     "Failed to find platform data\n");
 
 	ret = devm_mfd_add_devices(&spi->dev, PLATFORM_DEVID_NONE,
 				   sensorhub_sensor_devs,
-				   ARRAY_SIZE(sensorhub_sensor_devs), NULL, 0, NULL);
-	if (ret < 0) {
-		dev_err(&spi->dev, "mfd add devices fail\n");
-		return ret;
-	}
+				   ARRAY_SIZE(sensorhub_sensor_devs),
+				   NULL, 0, NULL);
+	if (ret < 0)
+		return dev_err_probe(&spi->dev, ret, "mfd add devices fail\n");
 
 	spi->mode = SPI_MODE_1;
 	ret = spi_setup(spi);
-	if (ret < 0) {
-		dev_err(&spi->dev, "Failed to setup spi\n");
-		return ret;
-	}
+	if (ret < 0)
+		return dev_err_probe(&spi->dev, ret, "Failed to setup spi\n");
 
 	data->fw_dl_state = SSP_FW_DL_STATE_NONE;
 	data->spi = spi;
@@ -573,14 +569,12 @@ static int ssp_probe(struct spi_device *spi)
 	data->fw_dl_state = ssp_check_fwbl(data);
 	if (data->fw_dl_state == SSP_FW_DL_STATE_NONE) {
 		ret = ssp_initialize_mcu(data);
-		if (ret < 0) {
-			dev_err(&spi->dev, "Initialize_mcu failed\n");
-			return ret;
-		}
-	} else {
-		dev_err(&spi->dev, "Firmware version not supported\n");
-		return -EPERM;
-	}
+		if (ret < 0)
+			return dev_err_probe(&spi->dev, ret,
+					     "Initialize_mcu failed\n");
+	} else
+		return dev_err_probe(&spi->dev, -EPERM,
+				     "Firmware version not supported\n");
 
 	return 0;
 }
-- 
2.34.1