Re: [PATCH v2] staging: octeon: remove SPI, POW, PKO, and Helper typedef enums

From: Dan Carpenter

Date: Wed Apr 15 2026 - 08:32:58 EST


On Wed, Apr 15, 2026 at 07:29:39AM -0500, Maxwell Doose wrote:
> This patch removes custom typedef enums and replaces them with standard
> enums to address the "General code review and cleanup" task in TODO.
>
> The following enums are affected:
>
> - cvmx_spi_mode_t (now enum cvmx_spi_mode)
> - cvmx_helper_interface_mode_t (now enum cvmx_helper_interface_mode_e)

Presumably the "_e" stands for enum? Ugh. No. Don't do that.

regards,
dan carpenter