Re: [PATCH v2] iio: frequency: ad9834: clean up includes

[Andy Shevchenko]

On Wed, Apr 15, 2026 at 11:20:30AM +0000, Joshua Crofts wrote:
> Cleanup include headers by removing proxy kernel.h
> header and unnecessary list.h, interrupt.h, workqueue.h
> and slab.h headers. Reordered remaining drivers

s/drivers/headers/

> alphabetically.
> 
> Verified using IWYU.

Probably you need to somehow elaborate that this is tool, IWYU is the acronym
of the principle, tool called 'iwyu'. Maybe adding a link?

"Verified with help of IWYU tool (...here is URL...).

> Signed-off-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>

...

> +#include <linux/bits.h>
>  #include <linux/clk.h>
> -#include <linux/interrupt.h>
> -#include <linux/workqueue.h>
>  #include <linux/device.h>
> -#include <linux/kernel.h>
> -#include <linux/slab.h>
> -#include <linux/sysfs.h>
> -#include <linux/list.h>
> -#include <linux/spi/spi.h>
> -#include <linux/regulator/consumer.h>
>  #include <linux/err.h>
>  #include <linux/module.h>
> +#include <linux/regulator/consumer.h>
> +#include <linux/spi/spi.h>
> +#include <linux/sysfs.h>

Still missing types.h, math.h, and probably more...

Yes, asm/byteorder.h, kstrtox.h, mutex.h. And maybe even more, I just
briefly scrolled over the driver code.

If you look at Git history of the replacement kernel.h in the drivers
you may find that usually it takes 10+ headers to be added.

-- 
With Best Regards,
Andy Shevchenko