Re: [PATCH 1/2] lib/string_helpers: drop redundant allocation in kasprintf_strarray

[Andy Shevchenko]

On Wed, Apr 15, 2026 at 02:25:43PM +0200, Thorsten Blum wrote:
> kasprintf_strarray() returns an array of N strings and kfree_strarray()
> also frees N entries.  However, kasprintf_strarray() currently allocates
> N+1 char pointers.  Allocate exactly N pointers instead of N+1.
> 
> Also update the kernel-doc for @n.

Have you checked all current users that they do not rely on the NULL terminated
array?

Note, that was done on purpose that once allocated it can allow user
to drop the track of the number of strings and rely on NULL terminator.
I.o.w.  the number of strings may be just a local variable somewhere
where kasprintf_strarray() is called.

I tend to NAK this change, rather you can update kernel-doc to explain
why it's done this way (see above).

-- 
With Best Regards,
Andy Shevchenko