Re: [PATCH v5 2/4] ASoC: codecs: Add TAS67524 quad-channel audio amplifier driver
From: Wang, Sen
Date: Wed Apr 15 2026 - 10:50:34 EST
On 4/14/2026 1:08 PM, Mark Brown wrote:
On Fri, Apr 10, 2026 at 12:56:47PM -0500, Sen Wang wrote:
On 4/10/26 09:02, Mark Brown wrote:
This looks mostly good, but one issue I see is that AFAICT we only stop(snip)
fault_check_work during runtime suspsend - if runtime PM is disabled, or
if the driver is removed, the work will be left running.
Do you think the DAPM fallback would suffice, or is the current approach
(poll until removal) acceptable given the hardware behavior? Any other
suggestions would be greatly appreciated!
It's fine to keep on checking for faults if there's faults that can be
generated, the only reason I mentioned runtime PM there was that it's
the only thing that stops the polling in the current version. So long
as everything is stopped when the device is removed it's fine. No need
for a DAPM fallback.
Understood, will make sure services (check_work/IRQ) are canceled when driver is removed for the next version.
Best,
Sen Wang