Re: [PATCH 1/1] crypto: sa2ul - Fix AEAD fallback algorithm names

[Chawdhry, Manorit]

Hi Pratham,

On 4/15/2026 8:06 PM, T Pratham wrote:
> For authenc AEAD algorithms, sa2ul is trying to register very specific
> -ce version as a fallback. This causes registration failure on SoCs
> which do not have ARMv8-CE enabled/available. Change the fallback
> algorithm from the specific driver name to generic algorithm name so
> that the kernel can allocate any available fallback.
>
> Fixes: d2c8ac187fc92 ("crypto: sa2ul - Add AEAD algorithm support")
> Signed-off-by: T Pratham <t-pratham@xxxxxx>
> ---
>   drivers/crypto/sa2ul.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c
> index df3defa1ef4b6..965a03d5b27ae 100644
> --- a/drivers/crypto/sa2ul.c
> +++ b/drivers/crypto/sa2ul.c
> @@ -1744,13 +1744,13 @@ static int sa_cra_init_aead(struct crypto_aead *tfm, const char *hash,
>   static int sa_cra_init_aead_sha1(struct crypto_aead *tfm)
>   {
>   	return sa_cra_init_aead(tfm, "sha1",
> -				"authenc(hmac(sha1-ce),cbc(aes-ce))");
> +				"authenc(hmac(sha1),cbc(aes))");
>   }
>   
>   static int sa_cra_init_aead_sha256(struct crypto_aead *tfm)
>   {
>   	return sa_cra_init_aead(tfm, "sha256",
> -				"authenc(hmac(sha256-ce),cbc(aes-ce))");
> +				"authenc(hmac(sha256),cbc(aes))");
>   }
>   
>   static void sa_exit_tfm_aead(struct crypto_aead *tfm)

Reviewed-by: Manorit Chawdhry <m-chawdhry@xxxxxx>

Regards,
Manorit