RE: [EXTERNAL] Re: [PATCH net] hv_sock: Report EOF instead of -EIO for FIN
From: Dexuan Cui
Date: Wed Apr 15 2026 - 13:21:10 EST
> From: Stefano Garzarella <sgarzare@xxxxxxxxxx>
> Sent: Wednesday, April 15, 2026 3:38 AM
> >@@ -703,8 +703,22 @@ static s64 hvs_stream_has_data(struct vsock_sock
> *vsk)
> > switch (hvs_channel_readable_payload(hvs->chan)) {
> > case 1:
> > need_refill = !hvs->recv_desc;
> >- if (!need_refill)
> >- return -EIO;
> >+ if (!need_refill) {
>
> Can we drop `need_refill` entirly and just check `hvs->recv_desc` here?
OK. Will post v2 later today.
> Mainly because now the comment we are adding is confusing me about what
> `need_refill` means.
>
> The rest LGTM.
>
> Thanks,
> Stefano
Thanks for the review!