Re: [PATCH v6 22/90] x86/cpuid: Introduce a parser debugfs interface

[Maciej Wieczor-Retman]

On 2026-03-27 at 03:15:36 +0100, Ahmed S. Darwish wrote:
>diff --git a/arch/x86/kernel/cpu/cpuid_debugfs.c b/arch/x86/kernel/cpu/cpuid_debugfs.c
>new file mode 100644
>index 000000000000..4bd874bffffc
>--- /dev/null
>+++ b/arch/x86/kernel/cpu/cpuid_debugfs.c
...
>+static __init int cpuid_init_debugfs(void)
>+{
>+	struct dentry *dir;
>+	uintptr_t cpu_id;
>+	char cpu_name[24];

nit: Reverse xmas tree variable ordering?

>+
>+	dir = debugfs_create_dir("cpuid", arch_debugfs_dir);
>+
>+	for_each_possible_cpu(cpu_id) {
>+		scnprintf(cpu_name, sizeof(cpu_name), "%lu", cpu_id);
>+		debugfs_create_file(cpu_name, 0444, dir, (void *)cpu_id, &cpuid_ops);
>+	}
>+
>+	return 0;
>+}

-- 
Kind regards
Maciej Wieczór-Retman