Re: [PATCH] dt-bindings: display: rockchip: dw-hdmi: Allow resets for Rockchip HDMI
From: Rob Herring
Date: Wed Apr 15 2026 - 18:04:50 EST
On Sat, Apr 04, 2026 at 05:04:34PM -0300, Fabio Estevam wrote:
> The Rockchip DW HDMI binding sets unevaluatedProperties: false while
> also inheriting from synopsys,dw-hdmi.yaml via allOf.
>
> The Synopsys binding defines the optional properties resets and
> reset-names, but due to dt-schema rules these are not considered
> allowed once unevaluatedProperties: false is set in the Rockchip
> schema unless they are re-declared locally.
That's not how unevaluatedProperties works. There is no resets nor
reset-names in synopsys,dw-hdmi.yaml.
>
> This went unnoticed because most Rockchip SoCs do not wire a reset line
> to the HDMI controller in their DTS. The rk3228, however, does use a
> reset, which causes dtbs_check to emit:
>
> Unevaluated properties are not allowed ('resets', 'reset-names')
>
> Re-declare these properties in the Rockchip schema so they are accepted
> when present, matching the capabilities of the underlying Synopsys IP
> and fixing the dtbs_check warning for rk3228.
>
> Signed-off-by: Fabio Estevam <festevam@xxxxxxxxx>
> ---
> .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> index 29716764413a..59fb084bb4fb 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> @@ -113,6 +113,12 @@ properties:
> - port@0
> - port@1
>
> + resets:
> + maxItems: 1
> +
> + reset-names:
> + const: hdmi
> +
> rockchip,grf:
> $ref: /schemas/types.yaml#/definitions/phandle
> description:
> --
> 2.43.0
>