Re: [PATCH net-next v9 04/10] net: phy: Create SFP phy_port before registering upstream

[Andrew Lunn]

On Wed, Apr 15, 2026 at 09:19:45AM +0200, Maxime Chevallier wrote:
> Hi Andrew,
> 
> On 15/04/2026 01:46, Andrew Lunn wrote:
> > On Fri, Apr 03, 2026 at 02:37:48PM +0200, Maxime Chevallier wrote:
> >> When dealing with PHY-driven SFP, we create a phy_port representing the
> >> SFP bus when we know we have such a bus.
> > 
> > I'm missing the big picture here.
> > 
> > Do we have three different things represented in the topology:
> > 
> > SFP bus-> SFP cage-> SFP module
> > 
> > 	Andrew
> 
> Ah by bad, this is a wording issue, this is the port for the cage indeed.
> 
> The model I ended-up with is to represent the SFP cage itself as a PHY
> port, but I've been calling that the "sfp bus port" in the code so far :/

I know we have sfp-bus.c, but i think most people think in terms of
cage and module. So unless we need some concepts from sfp-bus, i think
it would be better if we use phylink->sfp_cage_port and
phylink->mod_port. 

	Andrew