Re: [PATCH v2] nvme-auth: Include SC_C in RVAL controller hash

[Chris Leech]

On Thu, Apr 16, 2026 at 09:08:24AM +1000, alistair23@xxxxxxxxx wrote:
> From: Alistair Francis <alistair.francis@xxxxxxx>
> 
> Section 8.3.4.5.5 of the NVMe Base Specification 2.1 describes what is
> included in the Response Value (RVAL) hash and SC_C should be included.
> Currently we are hardcoding 0 instead of using the correct SC_C value.
> 
> Update the host and target code to use the SC_C when calculating the
> RVAL instead of using 0.
> 
> Fixes: f50fff73d620 ("nvme: implement In-Band authentication")
> Signed-off-by: Alistair Francis <alistair.francis@xxxxxxx>
> ---
> v2:
>  - Rebase using new nvme_auth_hmac_update() functions
> 
>  drivers/nvme/host/auth.c   | 3 ++-
>  drivers/nvme/target/auth.c | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)

Thanks, this was a good catch.  Fix looks good to me.

Reviewed-by: Chris Leech <cleech@xxxxxxxxxx>