Re: [PATCH] [v3] mtd: spi-nor: gigadevice: Add support for GD25LQ255E

[Michael Walle]

On Sat Apr 18, 2026 at 10:42 AM CEST, Weimin Wu wrote:
> Add support for the GigaDevice GD25LQ255E (JEDEC ID c8 60 19),
> a 256Mbit (32MB) SPI NOR flash chip which supports SFDP.
>
> The chip supports 4K sector erase, dual read, and quad read modes.
>
> Link: https://download.gigadevice.com/Datasheet/DS-00562-GD25LQ255E-Rev1.2.pdf

Please move the Link: tag above your SoB line.

..

> diff --git a/drivers/mtd/spi-nor/gigadevice.c b/drivers/mtd/spi-nor/gigadevice.c
> index ef1edd0ad..22a430798 100644
> --- a/drivers/mtd/spi-nor/gigadevice.c
> +++ b/drivers/mtd/spi-nor/gigadevice.c
> @@ -82,6 +82,10 @@ static const struct flash_info gigadevice_nor_parts[] = {
>  		.size = SZ_16M,
>  		.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB,
>  		.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
> +	}, {
> +		/* gd25lb256 */
> +		.id = SNOR_ID(0xc8, 0x60, 0x19),
> +		.flags = SPI_NOR_HAS_LOCK | SPI_NOR_4BIT_BP | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6,

Reviewed-by: Michael Walle <mwalle@xxxxxxxxxx>

It looks like the gd25q256 is also missing the 4BIT_BP flag. Could
you add second patch fixing that one, please?

FWIW, the GigaDevice datasheets are super confusing, sometimes there
are 5 BP bits, where the last one is the TB, sometimes there are 4
BP and 1 TB but only 3 BP bits are used..

-michael

Attachment: signature.asc
Description: PGP signature