Re: [PATCH v1] staging: rtl8723bs: remove shadowed bDumpRxPkt declaration
From: Andy Shevchenko
Date: Mon Apr 20 2026 - 04:31:11 EST
On Sun, Apr 19, 2026 at 11:05:43PM -0400, Yuho Choi wrote:
> DBG_RX_DUMP_EAP redeclares bDumpRxPkt inside validate_recv_frame(),
> shadowing the existing function-local variable. Drop the inner declaration
> and reuse the existing variable to avoid unnecessary shadowing.
> Co-developed-by: Myeonghun Pak <mhun512@xxxxxxxxx>
> Signed-off-by: Myeonghun Pak <mhun512@xxxxxxxxx>
> Co-developed-by: Ijae Kim <ae878000@xxxxxxxxx>
> Signed-off-by: Ijae Kim <ae878000@xxxxxxxxx>
> Co-developed-by: Taegyu Kim <tmk5904@xxxxxxx>
> Signed-off-by: Taegyu Kim <tmk5904@xxxxxxx>
> Signed-off-by: Yuho Choi <dbgh9129@xxxxxxxxx>
You are kidding me...
> drivers/staging/rtl8723bs/core/rtw_recv.c | 1 -
> 1 file changed, 1 deletion(-)
^^^^^^^^
--
With Best Regards,
Andy Shevchenko