Re: [PATCH v1 1/3] ASoC: codecs: lpass-wsa-macro: Switch to PM clock framework for runtime PM

[Ajay Kumar Nandam]

On 4/14/2026 2:16 PM, Konrad Dybcio wrote:
> On 4/13/26 2:18 PM, Ajay Kumar Nandam wrote:
> > Convert the LPASS WSA macro codec driver to use the PM clock framework
> > for runtime power management.
> >
> > The driver now relies on pm_clk helpers and runtime PM instead of
> > manually enabling and disabling macro, dcodec, mclk, npl, and fsgen
> > clocks. Runtime suspend and resume handling is delegated to the PM
> > core via pm_clk_suspend() and pm_clk_resume(), while existing runtime
> > PM callbacks continue to manage regcache state.
> >
> > This ensures clocks are enabled only when the WSA macro is active,
> > improves power efficiency on LPASS platforms supporting LPI/island
> > modes, and aligns the driver with common ASoC runtime PM patterns used
> > across Qualcomm LPASS codec drivers.
> >
> > Signed-off-by: Ajay Kumar Nandam <ajay.nandam@xxxxxxxxxxxxxxxx>
> > ---
>
> [...]
>
> > +	pm_runtime_set_autosuspend_delay(dev, 3000);
>
> FWIW I have mostly the same comments as on your other series
>
> Notably, msm-5.10 uses 50 ms of autosuspend delay for the macros
> (100 for VA for $reasons)

ACK, will post v2 accordinly

> Konrad