Re: [PATCH v2 2/2] Input: ads7846 - fix up the pendown GPIO setup on Nokia 770

From: Aaro Koskinen

Date: Mon Apr 20 2026 - 15:49:26 EST


Hi,

On Sun, Apr 19, 2026 at 05:06:53PM -0700, Dmitry Torokhov wrote:
> > - d = gpiod_get(NULL, "ads7846_irq", GPIOD_IN);
> > - if (IS_ERR(d))
> > - pr_err("Unable to get ADS7846 IRQ GPIO descriptor\n");
> > - else
> > - nokia770_spi_board_info[1].irq = gpiod_to_irq(d);
>
> No, I think what we need here is a simple gpiod_put(). The mapping is
> not going to change unless someone tries to unload gpiochip, but then
> the device is not going to work anyway.

OK, I will do that in v3. I tried unbind/re-bind the gpiochip before
loading the touchscreen module and yes, it seems to fail in consistent
manner without suprises (e.g. no crash, just probe failing).

A.