Re: [PATCH v1] staging: rtl8723bs: remove shadowed bDumpRxPkt declaration

[최유호]

Dear Greg, Andy, Ethan,

Thanks for the feedback.

This patch came from an ongoing research project with my fellow
researchers, and I included
the SOBs to reflect that collaboration. After reviewing the Linux
patch submission conventions
again, I agree that these tags should be limited to people who
directly contributed to the
specific patch itself. For this patch, that attribution was too broad.
I will be more careful about
that in future submissions.

I also understand the concern about the patch itself. I will trace the
logic more carefully.

Best regards,
Yuho Choi



On Mon, 20 Apr 2026 at 18:08, Ethan Tidmore <ethantidmore06@xxxxxxxxx> wrote:
>
> On Sun Apr 19, 2026 at 10:05 PM CDT, Yuho Choi wrote:
> > DBG_RX_DUMP_EAP redeclares bDumpRxPkt inside validate_recv_frame(),
> > shadowing the existing function-local variable. Drop the inner declaration
> > and reuse the existing variable to avoid unnecessary shadowing.
> >
> > Co-developed-by: Myeonghun Pak <mhun512@xxxxxxxxx>
> > Signed-off-by: Myeonghun Pak <mhun512@xxxxxxxxx>
> > Co-developed-by: Ijae Kim <ae878000@xxxxxxxxx>
> > Signed-off-by: Ijae Kim <ae878000@xxxxxxxxx>
> > Co-developed-by: Taegyu Kim <tmk5904@xxxxxxx>
> > Signed-off-by: Taegyu Kim <tmk5904@xxxxxxx>
> > Signed-off-by: Yuho Choi <dbgh9129@xxxxxxxxx>
>
> Could you explain why there are so many SOB here for such a simple
> change?
>
> Thanks,
>
> ET
>
> > ---
> >  drivers/staging/rtl8723bs/core/rtw_recv.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> > index 337671b1211f0..cf5698dda91fc 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> > @@ -1534,7 +1534,6 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
> >                       precvpriv->rx_drop++;
> >               } else if (retval == _SUCCESS) {
> >  #ifdef DBG_RX_DUMP_EAP
> > -                     u8 bDumpRxPkt;
> >                       u16 eth_type;
> >
> >                       /*  dump eapol */
>