Re: [PATCH v2 1/4] iio: magnetometer: ak8975: header cleanup
From: Joshua Crofts
Date: Tue Apr 21 2026 - 06:52:59 EST
On Tue, 21 Apr 2026 at 12:36, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> I just saw your reply to v1 thread. General advice would be slow down a bit.
> Even if you have reviews, a new patch set should sit for at least a few days
> to gather multiple reviews before a revision.
Yeah, I might've sent a v2 a bit earlier, next time I'll let it sit
longer before
sending a new version.
> For this sort of change I'd expect two patches.
> 1. Sort headers as is, not changes.
> 2. Add and remove headers.
>
> Both are good to do, but if you do them together as you had in v1
> it is annoyingly hard to review.
Fair, I can see why that would be annoying. I'll split it into two patches
in the v3 version.
--
Kind regards
CJD