Re: [PATCH] ASoC: fsl_micfil: Add DC output remover control

[Mark Brown]

On Tue, Apr 21, 2026 at 03:40:12PM +0800, Shengjiu Wang wrote:
> On Mon, Apr 20, 2026 at 8:50 PM Mark Brown <broonie@xxxxxxxxxx> wrote:

> > > +     /* Update DC Remover mode for all channels */
> > > +     ret = snd_soc_component_update_bits(comp, REG_MICFIL_DC_OUT_CTRL,
> > > +                                         MICFIL_DC_CTRL_CONFIG, reg_val);

> > This will return 0 not 1 when the value changes, meaning event
> > generation is missed.  The mixer-test selftest should report this.

> snd_soc_component_update_bits() will return 1 if the value is changed.
> and the mixer-test pass

Ah, so it will - I'm used to the regmap one which doesn't do that and
instead has a separate function to get a bool back for changes.  The
code is fine

Attachment: signature.asc
Description: PGP signature