Re: [PATCH 01/13] drm/msm: Remove obsolete perf infrastructure

[Rob Clark]

On Mon, Apr 20, 2026 at 4:49 PM Dmitry Baryshkov
<dmitry.baryshkov@xxxxxxxxxxxxxxxx> wrote:
>
> On Mon, Apr 20, 2026 at 03:25:23PM -0700, Rob Clark wrote:
> > Outside of a3xx, this was never really used.  And it low-key gets in the
> > way of the new perfcntr support (or at least it is confusing to have two
> > things called "perf").  So lets remove it.
> >
> > This drops the "perf" debugfs file.  But these days, nvtop is a better
> > option.  (Plus perfetto for newer gens.)
>
> Would it be possible to resurrect "perf" later? It was really useful.

Nothing is impossible.. but I was having trouble naming things with
both old and new perf stuff in parallel.  Is it really adding value
over nvtop?

BR,
-R

> Other than that,
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
>
> >
> > Signed-off-by: Rob Clark <robin.clark@xxxxxxxxxxxxxxxx>
> > ---
> >  drivers/gpu/drm/msm/Makefile          |   1 -
> >  drivers/gpu/drm/msm/adreno/a2xx_gpu.c |   7 -
> >  drivers/gpu/drm/msm/adreno/a3xx_gpu.c |  16 --
> >  drivers/gpu/drm/msm/adreno/a4xx_gpu.c |   3 -
> >  drivers/gpu/drm/msm/msm_debugfs.c     |   6 -
> >  drivers/gpu/drm/msm/msm_drv.c         |   1 -
> >  drivers/gpu/drm/msm/msm_drv.h         |   5 -
> >  drivers/gpu/drm/msm/msm_gpu.c         | 107 ------------
> >  drivers/gpu/drm/msm/msm_gpu.h         |  31 ----
> >  drivers/gpu/drm/msm/msm_perf.c        | 235 --------------------------
> >  10 files changed, 412 deletions(-)
> >  delete mode 100644 drivers/gpu/drm/msm/msm_perf.c
> >
>
> --
> With best wishes
> Dmitry