Re: [PATCH] staging: rtl8723bs: remove redundant else block in sdio_halinit.c

[Luka Gejak]

On Mon Apr 20, 2026 at 4:16 PM CEST, Demir Özdemir wrote:
> Remove redundant else block after a return statement within if block in
> rtl8723bs_hal_init(). Identified through checkpatch as a warning.
>
> Signed-off-by: Demir Özdemir <demirozdemir@xxxxxxxxxxx>
> ---
>  drivers/staging/rtl8723bs/hal/sdio_halinit.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> index f2f73c65a636..809f07855bb8 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> @@ -654,11 +654,11 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
>  		padapter->bFWReady = false;
>  		pHalData->fw_ractrl = false;
>  		return ret;
> -	} else {
> -		padapter->bFWReady = true;
> -		pHalData->fw_ractrl = true;
>  	}
>  
> +	padapter->bFWReady = true;
> +	pHalData->fw_ractrl = true;
> +
>  	rtl8723b_InitializeFirmwareVars(padapter);
>  
>  /* 	SIC_Init(padapter); */

LGTM.

Reviewed-by: Luka Gejak <luka.gejak@xxxxxxxxx>

Best regards,
Luka Gejak