Re: [PATCH] dt-bindings: iio: dac: mcp47feb02: Fix I2C address in example
From: Jonathan Cameron
Date: Tue Apr 21 2026 - 11:05:43 EST
On Tue, 21 Apr 2026 14:09:48 +0000
<Ariana.Lazar@xxxxxxxxxxxxx> wrote:
> Hello Jonathan,
>
> > > @@ -280,23 +280,23 @@ examples:
> > >
> > > #address-cells = <1>;
> > > #size-cells = <0>;
> > > - dac@0 {
> > > - compatible = "microchip,mcp47feb02";
> > > - reg = <0>;
> > > - vdd-supply = <&vdac_vdd>;
> > > - vref-supply = <&vref_reg>;
> > > + dac@60 {
> > > + compatible = "microchip,mcp47feb02";
> > Why is this indent changing?
> >
> > > + reg = <0x60>;
> > > + vdd-supply = <&vdac_vdd>;
> > > + vref-supply = <&vref_reg>;
> > >
> > > - #address-cells = <1>;
> > > - #size-cells = <0>;
> > > - channel@0 {
> > > - reg = <0>;
> > > - label = "Adjustable_voltage_ch0";
> > > - };
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > + channel@0 {
> > > + reg = <0>;
> > > + label = "Adjustable_voltage_ch0";
> > > + };
> > >
> > > - channel@1 {
> > > - reg = <0x1>;
> > > - label = "Adjustable_voltage_ch1";
> > > - };
> > > - };
> > > + channel@1 {
> > > + reg = <0x1>;
> > > + label = "Adjustable_voltage_ch1";
> > > + };
> > > + };
> > > };
> > > ...
> >
>
> Thank you for the review.
>
> 1. I updated the example indentation in order to use consistent 4-
> space indentation, instead of mixing with 2-space as in the
> previous version.
>
If that is needed, two patches. One that makes the address fix, then
a follow up to fix the indentation with no functional changes.
thanks,
Jonathan
> Best regards,
> Ariana
>