Re: [PATCH v8 2/2] platform: Add initial synology microp driver

From: Krzysztof Kozlowski

Date: Tue Apr 21 2026 - 11:34:46 EST


On 20/04/2026 16:24, Markus Probst wrote:
> + // pineview
> + (DeviceId::new(c"synology,ds710p-microp"), Model::new().led_esata()),
> + (DeviceId::new(c"synology,ds1010p-microp"), Model::new().led_alert(Color::Orange)),
> + (DeviceId::new(c"synology,ds411p-microp"), Model::new()),
> +
> + // r1000
> + (DeviceId::new(c"synology,ds923p-microp"), Model::new()),
> + (DeviceId::new(c"synology,ds723p-microp"), Model::new()),
> + (DeviceId::new(c"synology,ds1522p-microp"), Model::new()),

What is this all doing here? Again, what is the fallback and front
compatible? Why do you keep duplicating all this when I asked to REMOVE
the completely unnecessary front compatibles?

So it is not only schema which is wrong, but your driver makes no sense
with it.

Best regards,
Krzysztof