Re: [PATCH v8 2/2] platform: Add initial synology microp driver

[Ilpo Järvinen]

On Tue, 21 Apr 2026, Markus Probst wrote:

> On Tue, 2026-04-21 at 21:10 +0300, Ilpo Järvinen wrote:
> > On Tue, 21 Apr 2026, Markus Probst wrote:
> > 
> > > On Tue, 2026-04-21 at 14:59 +0300, Ilpo Järvinen wrote:
> > > > On Mon, 20 Apr 2026, Markus Probst wrote:
> > > > 
> > > > > Add a initial synology microp driver, written in Rust.
> > > > > The driver targets a microcontroller found in Synology NAS devices. It
> > > > > currently only supports controlling of the power led, status led, alert
> > > > > led and usb led. Other components such as fan control or handling
> > > > > on-device buttons will be added once the required rust abstractions are
> > > > > there.
> > > > > 
> > > > > This driver can be used both on arm and x86, thus it goes into the root
> > > > > directory of drivers/platform.
> > > > > 
> > > > > Tested successfully on a Synology DS923+.
> > > > > 
> > > > > Signed-off-by: Markus Probst <markus.probst@xxxxxxxxx>
> > > > > ---
> > > > >  MAINTAINERS                                        |   6 +
> > > > >  drivers/platform/Kconfig                           |   2 +
> > > > >  drivers/platform/Makefile                          |   1 +
> > > > >  drivers/platform/synology_microp/Kconfig           |  13 +
> > > > >  drivers/platform/synology_microp/Makefile          |   3 +
> > > > >  drivers/platform/synology_microp/TODO              |   7 +
> > > > >  drivers/platform/synology_microp/command.rs        |  54 ++++
> > > > >  drivers/platform/synology_microp/led.rs            | 281 +++++++++++++++++++++
> > > > >  drivers/platform/synology_microp/model.rs          |  49 ++++
> > > > >  .../platform/synology_microp/synology_microp.rs    | 110 ++++++++
> > > > >  10 files changed, 526 insertions(+)
> > > > > 
> > > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > > index c1c686846cdd..49f08290eed0 100644
> > > > > --- a/MAINTAINERS
> > > > > +++ b/MAINTAINERS
> > > > > @@ -25555,6 +25555,12 @@ F:	drivers/dma-buf/sync_*
> > > > >  F:	include/linux/sync_file.h
> > > > >  F:	include/uapi/linux/sync_file.h
> > > > >  
> > > > > +SYNOLOGY MICROP DRIVER
> > > > > +M:	Markus Probst <markus.probst@xxxxxxxxx>
> > > > 
> > > > You should probably add:
> > > > 
> > > > L:	platform-driver-x86@xxxxxxxxxxxxxxx
> > > > 
> > > > Through which tree the patches to this driver are generally expected to be 
> > > > picked up?
> > > 
> > > I suppose platform-drivers-x86.
> > 
> > Okay (with the platform drivers maintainer hat on). Just don't expect me 
> > to have deep Rust knowledge.
> > 
> > > The driver itself can be used both on
> > > x86 and arm64. Although I also have seen Synology devices with PowerPC
> > > (no device with PowerPC is supported in the driver yet). 
> > 
> > In practice platform drivers scope has already expanded beyond x86 so the 
> > platform-drivers-x86 list naming is just a historic artifact.
>
> Does this also include the drivers/platform/x86 folder?
> 
> Because of the multiple architectures, I put it into the root, i. e.
> drivers/platform/synology_microp/
> 
> Is this fine or should I move it into drivers/platform/x86 ?

No. The current place you have it is fine with me.

There's actually a small number of files that have migrated away from x86/ 
when they've become useful for non-x86 systems.

> > > > > +S:	Maintained
> > > > > +F:	Documentation/devicetree/bindings/embedded-controller/synology,ds1825p-microp.yaml
> > > > > +F:	drivers/platform/synology_microp/
> > > > > +
> > > > >  SYNOPSYS ARC ARCHITECTURE
> > > > >  M:	Vineet Gupta <vgupta@xxxxxxxxxx>
> > > > >  L:	linux-snps-arc@xxxxxxxxxxxxxxxxxxx

-- 
 i.