Re: [PATCH] ASoC: qcom: x1e80100: limit speaker volumes

[Mark Brown]

On Tue, Apr 21, 2026 at 10:07:25PM +0200, Tobias Heider wrote:
> On Tue, Apr 21, 2026 at 6:27 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
> > On Tue, Apr 21, 2026 at 02:07:58PM +0200, Tobias Heider wrote:

> > > +             snd_soc_limit_volume(card, "WSA_RX0 Digital Volume", 81);
> > > +             snd_soc_limit_volume(card, "WSA_RX1 Digital Volume", 81);

> > Do these actually match?  The hamoa WSA devices look like they've got
> > sound-name-prefix specified so the actual controls will have WSA and

> I think you might be right but I am not too experienced with alsa so I could use
> some help to figure out if what I'm doing makes sense.

> I ran `amixer -c0 controls` and that actually shows the prefixed names
> as you said.
> `amixer -c0 cget name="WSA WSA_RX0 Digital Volume"` also confirms that they are
> still listing max=124, so it looks like it indeed didn't work.

Right.

> From what I understand the correct fix would be listing all four as in:
> snd_soc_limit_volume(card, "WSA WSA_RX0 Digital", 81);
> snd_soc_limit_volume(card, "WSA WSA_RX1 Digital", 81);
> snd_soc_limit_volume(card, "WSA2 WSA_RX0 Digital", 81);
> snd_soc_limit_volume(card, "WSA2 WSA_RX1 Digital", 81);

> Does that sound correct?

Yes, I think so.

> I'll run a few tests and send a fixed version once I have verified
> that works and amixer
> prints the correct max limit.

I sent a patch earlier this evening which adds an error message if the
control isn't matched, hopefully that's helpful.

Attachment: signature.asc
Description: PGP signature