RE: [PATCH v2] iio: orientation: hid-sensor-rotation: use ext_scan_type
From: Zhang, Lixu
Date: Tue Apr 21 2026 - 21:09:04 EST
Tested-by: Lixu Zhang <lixu.zhang@xxxxxxxxx>
>-----Original Message-----
>From: srinivas pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
>Sent: Monday, April 20, 2026 11:46 PM
>To: Jonathan Cameron <jic23@xxxxxxxxxx>; Lechner, David
><dlechner@xxxxxxxxxxxx>; Zhang, Lixu <lixu.zhang@xxxxxxxxx>
>Cc: Jiri Kosina <jikos@xxxxxxxxxx>; Nuno Sá <nuno.sa@xxxxxxxxxx>; Andy
>Shevchenko <andy@xxxxxxxxxx>; linux-input@xxxxxxxxxxxxxxx; linux-
>iio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
>Subject: Re: [PATCH v2] iio: orientation: hid-sensor-rotation: use ext_scan_type
>
>+Lixu
>
>On Sun, 2026-04-12 at 15:26 +0100, Jonathan Cameron wrote:
>> On Sun, 01 Mar 2026 17:46:48 -0600
>> David Lechner <dlechner@xxxxxxxxxxxx> wrote:
>>
>> > Make use of ext_scan_type to handle the dynamic realbits size of the
>> > quaternion data. This lets us implement it using static data rather
>> > than having to duplicate the channel info for each driver instance.
>> >
>> > Signed-off-by: David Lechner <dlechner@xxxxxxxxxxxx>
>> > ---
>> I'm going to apply this now, but would welcome any additional feedback
>> from Srinivas or others.
>>
>> Note, given this is next cycle material now I'll only push the tree
>> out as testing until I can rebase on rc1.
>>
>
>In real world I think report size is always 16 copying from spec.
Yes, it's always 16 for Intel ISH.
Thanks,
Lixu
>
> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
>
>Thanks,
>Srinivas
>
>
>> Thanks,
>>
>> Jonathan
>>