Re: [PATCH net 11/18] drivers: net: cirrus: cs89x0: Remove this driver

[Geert Uytterhoeven]

Hi Andrew,

On Wed, 22 Apr 2026 at 03:04, Andrew Lunn <andrew@xxxxxxx> wrote:
> The cs89x0 was written by Bonald Becker 1993 to 1994. It is an ISA
> device, so unlikely to be used with modern kernels.
>
> Signed-off-by: Andrew Lunn <andrew@xxxxxxx>

Thanks for your patch!

> --- a/drivers/net/ethernet/cirrus/Kconfig
> +++ b/drivers/net/ethernet/cirrus/Kconfig
> @@ -17,36 +17,6 @@ config NET_VENDOR_CIRRUS
>
>  if NET_VENDOR_CIRRUS
>
> -config CS89x0
> -       tristate
> -
> -config CS89x0_ISA
> -       tristate "CS89x0 ISA driver support"
> -       depends on HAS_IOPORT_MAP
> -       depends on ISA
> -       depends on !PPC32
> -       depends on CS89x0_PLATFORM=n
> -       select NETDEV_LEGACY_INIT
> -       select CS89x0
> -       help
> -         Support for CS89x0 chipset based Ethernet cards. If you have a
> -         network (Ethernet) card of this type, say Y and read the file
> -         <file:Documentation/networking/device_drivers/ethernet/cirrus/cs89x0.rst>.
> -
> -         To compile this driver as a module, choose M here. The module
> -         will be called cs89x0.

This is the driver for the old twentieth-century ISA device...

> -
> -config CS89x0_PLATFORM
> -       tristate "CS89x0 platform driver support"
> -       depends on ARM || (COMPILE_TEST && !PPC)
> -       select CS89x0
> -       help
> -         Say Y to compile the cs89x0 platform driver. This makes this driver
> -         suitable for use on certain evaluation boards such as the iMX21ADS.
> -
> -         To compile this driver as a module, choose M here. The module
> -         will be called cs89x0.

This is the more modern DT-based part...

> --- a/drivers/net/ethernet/cirrus/cs89x0.c
> +++ /dev/null

> -#if IS_ENABLED(CONFIG_CS89x0_PLATFORM)

[...]

> -static const struct of_device_id __maybe_unused cs89x0_match[] = {
> -       { .compatible = "cirrus,cs8900", },
> -       { .compatible = "cirrus,cs8920", },
> -       { },
> -};
> -MODULE_DEVICE_TABLE(of, cs89x0_match);

[...]

> -#endif /* CONFIG_CS89x0_PLATFORM */

However, no users of these compatible values ever appeared upstream.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds