Re: [PATCH 1/6] spi: cadence-quadspi: fix runtime pm disable imbalance on probe failure
From: Miquel Raynal
Date: Wed Apr 22 2026 - 04:27:14 EST
Hi,
On 21/04/2026 at 14:53:49 +02, Johan Hovold <johan@xxxxxxxxxx> wrote:
> A recent attempt to fix the probe error handling introduced a runtime PM
> disable depth imbalance by incorrectly disabling runtime PM on early
> failures (e.g. probe deferral).
>
> Fixes: f18c8cfa4f1a ("spi: cadence-qspi: Fix probe error path and remove")
> Cc: stable@xxxxxxxxxxxxxxx # 7.0
> Cc: Miquel Raynal (Schneider Electric) <miquel.raynal@xxxxxxxxxxx>
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
Reading it again, I probably got confused by the impact of
pm_runtime_set_active(), what you propose looks correct.
Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
Thanks,
Miquèl