Re: [PATCH v3] media: atomisp: csi2: Fix DPCM decompression for source pad format

[Sakari Ailus]

Hi Dabjeet,

On Wed, Apr 22, 2026 at 04:46:49PM +0530, Debjeet Banerjee wrote:
> On Wed, Apr 22, 2026 at 01:46:33PM +0300, Sakari Ailus wrote:
> > It may well be but the rest of the driver doesn't appear to support DPCM
> > uncompression. Rather than trying to pretend it does, I'd instead just
> > remove any references to it.
> 
> Thanks for the feedback Sakari.
> 
> So if I understand correctly, the right fix here is to remove all the
> DPCM-related dead code: compressed_codes[], atomisp_subdev_uncompressed_code(),
> atomisp_subdev_is_compressed(), and atomisp_find_in_fmt_conv_compressed()
> declaration 
> 
> And in atomisp_csi2.c just keep the source pad copying the sink format as before, 
> but drop the FIXME comment since we're explicitly acknowledging DPCM is not supported?
> 
> Please let me know if I'm on the right track before I send v4 of this patch.

That's how it looks like to me, too.

-- 
Regards,

Sakari Ailus