Re: [PATCH v4 2/5] phy: qcom: edp: Add eDP/DP mode switch support

[Yongxing Mou]

On 4/23/2026 12:14 AM, Dmitry Baryshkov wrote:
> On Wed, Apr 22, 2026 at 02:01:52PM +0800, Yongxing Mou wrote:
> > The eDP PHY supports both eDP/DP modes, each requires a different table.
> > The current driver doesn't support both modes and use either the eDP or
> > DP table when enable the platform.
>
> This is not quite true. The driver supports both modes, but it uses a
> fixed static table for eDP programming.
>
> Other than the commit message, LGTM.
Will modify next patch.
> > Add a separate set of tables for eDP
> > and DP modes, and select the appropriate table based on the current mode.
> >
> > Glymur's DP mode table differs from the other platforms, add a dedicated
> > table for it.
> >
> > Since both modes are supported, so also fixes the table mismatch for
> > X1E80100(eDP) and SA8775P(DP).
> >
> > Cc: stable@xxxxxxxxxxxxxxx
> > Fixes: 3f12bf16213c ("phy: qcom: edp: Add support for eDP PHY on SA8775P")
> > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Yongxing Mou <yongxing.mou@xxxxxxxxxxxxxxxx>
> > ---
> >   drivers/phy/qualcomm/phy-qcom-edp.c | 46 +++++++++++++++++++++++++++----------
> >   1 file changed, 34 insertions(+), 12 deletions(-)