Re: [PATCH V5 0/2] Add post change sequence for link start notify

[Palash Kambar]

On 4/22/2026 9:42 PM, Manivannan Sadhasivam wrote:
> On Wed, Apr 22, 2026 at 05:19:37PM +0530, palash.kambar@xxxxxxxxxxxxxxxx wrote:
>> From: Palash Kambar <palash.kambar@xxxxxxxxxxxxxxxx>
>>
>> This patch series introduces two updates to the UFS subsystem aimed at
>> improving link stability and power efficiency on platforms using the
>> Qualcomm UFS host controller.
>>
>> During link startup, the number of connected TX/RX lanes discovered may be
>> fewer than the lanes specified in the device tree. The current UFS core
>> driver configures all DT-defined lanes unconditionally, which can lead to
>> mismatches during power mode changes. Patch 1/2 ensures to fail on this.
>>
>> Additionally, certain Qualcomm platforms support Auto Hibern8 (AH8), where
>> the UFS controller autonomously de-asserts clk_req signals to the GCC
>> during Hibern8 state. Enabling this mechanism allows the clock controller
>> to gate unused clocks, providing meaningful power savings. Patch 2/2 adds
>> support for enabling this feature as recommended by the Hardware
>> Programming Guidelines.
>>
>> ---
>> changes from V1
>> 1) Addressed Shawn Lin's comments to fix comment to connected lanes.
>> 2) Addressed Bart's comments to remove warning and trigger failure
>>    incase of lane mismatch.
>>
>> changes from V2:
>> 1) Addressed Shawn's comments to fix commit text.
>> 2) Addressed Bart's comments to remove variable initializations and
>>    indentation fix.
>>
>> changes from V3:
>> 1) Addressed Manivannan's comments to remove extra comment and return
>>    logic.
>>
>> changes from V4:
>> 1) Addressed Manivannan's comments to fix indentation and return
>>    handling.
> 
> And you dropped all tags given in v3 :(
> 

Sorry, missed the tags, will add and reshare.

> 
>>
>> Palash Kambar (2):
>>   ufs: core: Configure only active lanes during link
>>   ufs: ufs-qcom: Enable Auto Hibern8 clock request support
>>
>>  drivers/ufs/core/ufshcd.c   | 35 +++++++++++++++++++++++++++++++++++
>>  drivers/ufs/host/ufs-qcom.c | 10 ++++++++++
>>  drivers/ufs/host/ufs-qcom.h | 11 +++++++++++
>>  3 files changed, 56 insertions(+)
>>
>> -- 
>> 2.34.1
>>
>