Re: [PATCH v4 0/5] phy: qcom: edp: Add DP/eDP switch for phys

[Yongxing Mou]

On 4/23/2026 1:24 AM, Dmitry Baryshkov wrote:
> On Wed, Apr 22, 2026 at 02:01:50PM +0800, Yongxing Mou wrote:
> > Currently the PHY selects the DP/eDP configuration tables in a fixed way,
> > choosing the table when enable. This driver has known issues:
> > 1. The selected table does not match the actual platform mode.
> > 2. It cannot support both modes at the same time.
> >
> > As discussed here[1], this series:
> > 1. Cleans up duplicated and incorrect tables based on the HPG.
> > 2. Fixes the LDO programming error in eDP mode.
> > 3. Adds DP/eDP mode switching support.
> >
> > Note: x1e80100/sa8775p/sc7280/SC8280XP have been tested, while
>
> Tested with eDP or with mini-DP too?
x1e80100 eDP (hamoa-evk)
sa8775p DP(full-size)
sc7280 (rb3, mini-DP)
sorry for sa8775p mini-DP... i don't have the hardware to test.
> > glymur/sc8180x have not been tested.
> >
> > [1] https://lore.kernel.org/all/20260119-klm_dpphy-v2-1-52252190940b@xxxxxxxxxxxxxxxx/
> >
> > Signed-off-by: Yongxing Mou <yongxing.mou@xxxxxxxxxxxxxxxx>
> > ---
> > Changes in v4:
> > - Splite changes.[Dmitry]
> > - Add sc8180x tables in a single chagne.[Dmitry][Konrad]
> > - Link to v3: https://lore.kernel.org/r/20260302-edp_phy-v3-0-ca8888d793b0@xxxxxxxxxxxxxxxx
> >
> > Changes in v3:
> > - Rebase to next-20260224.[Dmitry]
> > - Only enable TX1 LDO when lane counts > 2.[Konrad]
> > - Link to v2: https://lore.kernel.org/all/20260213-edp_phy-v2-0-43c40976435e@xxxxxxxxxxxxxxxx/
> >
> > Changes in v2:
> > - Combine the third patch with the first one.[Dmitry]
> > - Fix code formatting issues.[Konrad][Dmitry]
> > - Update the commit message description.[Dmitry][Konrad]
> > - Fix kodiak swing/pre_emp table values.[Konrad]
> >
> > ---
> > Yongxing Mou (5):
> >        phy: qcom: edp: Unify generic DP/eDP swing and pre-emphasis tables
> >        phy: qcom: edp: Add eDP/DP mode switch support
> >        phy: qcom: edp: Add SC7280/SC8180X swing/pre-emphasis tables
> >        phy: qcom: edp: Fix AUX_CFG8 programming for DP mode
> >        phy: qcom: edp: Add PHY-specific LDO config for eDP low vdiff
> >
> >   drivers/phy/qualcomm/phy-qcom-edp.c | 221 ++++++++++++++++++++++++++++--------
> >   1 file changed, 173 insertions(+), 48 deletions(-)
> > ---
> > base-commit: bee6ea30c48788e18348309f891ed8afbf7702ac
> > change-id: 20260205-edp_phy-1eca3ed074c0
> >
> > Best regards,
> > --
> > Yongxing Mou <yongxing.mou@xxxxxxxxxxxxxxxx>
> >
> >
> > --
> > linux-phy mailing list
> > linux-phy@xxxxxxxxxxxxxxxxxxx
> > https://lists.infradead.org/mailman/listinfo/linux-phy