Re: [PATCH 3/7] media: qcom: iris: Fix bitmask test in iris_allow_cmd()

From: Bryan O'Donoghue

Date: Thu Apr 23 2026 - 05:37:29 EST


On 22/04/2026 12:16, Dikshita Agarwal wrote:
iris_allow_cmd() incorrectly tests a single sub‑state bit using a scalar
comparison

I don't think scalar is the right term here. You're changing logical comparison to bit-wise comparison.

Otherwise

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>

---
bod