Re: [PATCH] PCI: dwc: Initialize pp->lock before MSI domain registration

From: Yadu M G

Date: Thu Apr 23 2026 - 09:47:57 EST



On 4/21/2026 6:52 AM, Shawn Lin wrote:
> Moreover, sophgo_pcie_host_init() calls sophgo_pcie_msi_enable() which
> need to acquires pp->lock with a uninitialized lock with your patch now.
> That could possible break all other variant drivers which need this lock
> in the .init() callback.
>
Agreed — pp->lock must be initialized even when MSI is disabled.

I'll keep the init in dw_pcie_host_init() and add a one-time init in
dw_pcie_allocate_domains() for direct callers, then resend.

Thanks,
Yadu