Re: [PATCH v5 01/14] ASoC: dt-bindings: sound: Add DT binding for RZ/G3E sound

[Geert Uytterhoeven]

Hi John,

On Fri, 24 Apr 2026 at 03:39, John Madieu <john.madieu.xa@xxxxxxxxxxxxxx> wrote:
> > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> > On Wed, Apr 15, 2026 at 12:47:18PM +0000, John Madieu wrote:
> > > Add a standalone device tree binding for the Renesas RZ/G3E
> > > (R9A09G047) sound controller.
> > >
> > > The RZ/G3E sound IP is based on R-Car Sound but differs in several ways:
> > > - Uses unprefixed sub-node names (ssi, ssiu, src, dvc, mix, ctu) instead
> > >   of R-Car's rcar_sound,xxx prefixed names.
> > > - Supports up to 5 DMA controllers per direction, allowing multiple DMA
> > >   entries with repeated channel names in SSIU, SRC and DVC sub-nodes.
> > > - Has 47 clocks including per-SSI ADG clocks (adg.ssi.0-9), SCU clocks
> > >   (scu, scu_x2, scu_supply), SSIF supply clock, AUDMAC peri-peri clock,
> > >   and ADG clock.
> > > - Has 14 reset lines including SCU, ADG and AUDMAC peri-peri resets.
> > > - SSI operates exclusively in BUSIF mode.
> > >
> > > These differences make the RZ/G3E binding incompatible with the
> > > existing renesas,rsnd.yaml, so it is added as a separate standalone
> > > binding with its own $ref to dai-common.yaml.
> > >
> > > Signed-off-by: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>

> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.
> > > +++ yaml

> > > +  "#sound-dai-cells":
> > > +    enum: [0, 1]
> >
> > Why is this flexible? That's a defined device meaning you have one XOR
> > more DAIs. Not "1 and more".
>
> The IP exposes ten independent SSI interfaces, and a board can
> reasonably wire either a single SSI to one codec or several SSIs
> to several codecs. The cells value follows that wiring: 0 when
> the phandle is `<&rcar_sound>` for the single-DAI case, 1 when
> it is `<&rcar_sound N>` selecting a specific DAI index.

How does this work if both types of wiring are present?
e.g. SSI1 wired to one codec, and SSI2-4 wired to several codecs?

> > > +  clock-names:
> > > +    items:
> > > +      - const: ssi-all
> > > +      - const: ssi.9
> >
> > Use consistently -
>
> Agreed, I'll switch to hyphens for all indexed entries
> in both lists (ssi-0..9, src-0..9, mix-0..1, ctu-0..7,
> dvc-0..1, adg-ssi-0..9).
>
> > > +      - const: ssi.8
> > > +      - const: ssi.7
> > > +      - const: ssi.6
> > > +      - const: ssi.5
> > > +      - const: ssi.4
> > > +      - const: ssi.3
> > > +      - const: ssi.2
> > > +      - const: ssi.1
> > > +      - const: ssi.0
> > > +      - const: src.9
> > > +      - const: src.8
> > > +      - const: src.7
> > > +      - const: src.6
> > > +      - const: src.5
> > > +      - const: src.4
> > > +      - const: src.3
> > > +      - const: src.2
> > > +      - const: src.1
> > > +      - const: src.0
> > > +      - const: mix.1
> > > +      - const: mix.0
> > > +      - const: ctu.1
> > > +      - const: ctu.0

Why are these listed in descending order...

> > > +      - const: dvc.0
> > > +      - const: dvc.1

... and these in ascending order?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds