Re: [PATCH v2 0/3] pinctrl: qcom: lpass-lpi: Switch to PM clock framework

[Ajay Kumar Nandam]

On 4/22/2026 4:29 PM, Konrad Dybcio wrote:
> On 4/20/26 2:31 PM, Ajay Kumar Nandam wrote:
> > This series moves LPASS LPI pinctrl runtime clock control to the PM
> > clock framework and ensures GPIO register accesses runtime-resume the
> > block before MMIO.
> >
> > The common LPASS LPI core now uses PM clocks and autosuspend. Runtime PM
> > callbacks are wired for all LPASS LPI variant drivers sharing the common
> > core so behavior is consistent across SoCs using DT-provided clocks via
> > of_pm_clk_add_clks().
> >
> > ---
> > v1: lore.kernel.org/r/20260413122233.375945-1-ajay.nandam@xxxxxxxxxxxxxxxx
> >
> > Changes since v1:
> > - Kept GPIO helper return type adjustments in the runtime PM access
> >    patch and switched access paths to pm_runtime_resume_and_get()
> > - Added runtime PM callback wiring for remaining LPASS LPI SoC drivers
> >    (sc8280xp, sm4250, sm6115, sm8250, sm8450, sm8550, sm8650)
> > - Addressed style nits in GPIO access helper declaration formatting
>
> Each patch must be self-contained and not break functionality or build,
> so that bisect always works
>
> If I only apply patch 1, non-7280 platforms will still regress because
> the changes made in patch 1 require that pm_ops is set for the clocks
> to get enabled (otherwise it'll just autosuspend 100ms after probe and
> any subsequent accesses will crash the device)

Agreed on bisect safety, will reorder the series in the next version.

Thanks
Ajay Kumar Nandam

> Konrad