Re: [PATCH RFT v2] media: atomisp: Add error check in create_host_regular_capture_pipeline()

[Andy Shevchenko]

On Fri, Apr 24, 2026 at 03:15:38PM +0700, Robertus Diawan Chris wrote:
> When calling ia_css_pipeline_create_and_add_stage() function, there's no
> condition to check whether ia_css_pipeline_create_and_add_stage() throw
> an error or not. So add conditional check for the return value of
> ia_css_pipeline_create_and_add_stage() function.

> This is reported by Coverity Scan with CID 1408952 as UNUSED_VALUE.

Unneeded detail in the commit message. Use the comment block for that (as there
changelog right now and other stuff you explained).

> Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
> Signed-off-by: Robertus Diawan Chris <robertusdchris@xxxxxxxxx>
> ---
> v1 -> v2: Add Fixes tag (suggested by Dan Carpenter).
> 
> v1:
> https://lore.kernel.org/all/20260423060246.296986-1-robertusdchris@xxxxxxxxx/
> 
> I am not sure if omitting the error check is intentional or not, but from
> what I see from another ia_css_pipeline_create_and_add_stage() usage
> in the same function, we check the return value after the call and return
> the error code if it's non-zero.

Okay, while this observation sounds like a +1 to the suggested change,
you still need to dive into the code and try to get if
ia_css_pipeline_create_and_add_stage() failure is fatal or not for
create_host_regular_capture_pipeline().

> I also don't have the device to test this change.

It's a pity as this driver is quite complicated thing...

-- 
With Best Regards,
Andy Shevchenko