Re: [PATCH v3 0/2] mcb: enable register PCI devices using any BAR

[Johannes Thumshirn]

On 3/4/26 2:26 PM, Filip Jensen wrote:
> V2 -> V3: Thanks for second review. Fixed declaring pci_dev outside of the
> only block where it is needed in patch 1/2.
> V1 -> V2: Thanks to the review from Johannes Thumshirn, the patch 2/3 of
> the first version has been removed and the cleaner solution from patch 3/3
> is then kept.
>
> The PCI mcb driver is currently only able to register devices that use
> the first PCI BAR. That is hardcoded in mcb-parse.c in lines 156-161:
>
>                  c = kzalloc_obj(struct chameleon_bar);
>                  if (!c)
>                          return -ENOMEM;
>
>                  bar_count = 1;
>                  c->addr = mapbase;
>
> However, mcb devices can use other indexes of the 6 PCI BARs. This serie of
> patches allows to use these devices by adding the relevant PCI BAR info to
> the chameleon table. As this code must also work for lpc devices, it has
> been done a refactoring in order to keep the two buses dependent operations
> regarding bars (get_bar and is_io_mapped_bar) outside of the common parsing
> code. These callback operations are stored in a structure and passed over
> to the parser, thus rendering each module, the mcb-lpc and mcb-pci, only
> with their own bus relevant logic.
>
> This patch depends on the previously accepted patch:
> Link: https://lore.kernel.org/lkml/20260217075124.10052-1-dev-Felipe.Jensen@xxxxxxxxxx/
>
> Reviewed-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@xxxxxxxxxx>


Added to mcb-for-next.

Sorry for the delay.

Byte,

    Johannes