Re: [PATCH v5 3/6] arm64: dts: qcom: Add AYN QCS8550 Common

[Konrad Dybcio]

On 4/8/26 9:41 PM, Aaron Kling via B4 Relay wrote:
> From: Teguh Sobirin <teguh@xxxxxxxx>
> 
> This contains everything common between the AYN QCS8550 devices. It will
> be included by device specific dts'.
> 
> Signed-off-by: Teguh Sobirin <teguh@xxxxxxxx>
> Co-developed-by: Aaron Kling <webgeek1234@xxxxxxxxx>
> Signed-off-by: Aaron Kling <webgeek1234@xxxxxxxxx>
> ---

[...]

> +	// The tzlog label is required by ABL to apply a dtbo, but it can be on any node

I don't know if the policy changed, but I think C-style (/* Foo */)
comments are still preferred

[...]


> +	// The arch_timer label is unused here, but is required by ABL to apply a dtbo
> +	arch_timer: timer { };

ditto

[...]

> +&pm8550_gpios {
> +	fan_pwm_active: fan-pwm-active-state {
> +		pins = "gpio8";
> +		function = "func1";
> +		input-disable;
> +		output-enable;
> +		output-low;

Looks like this should be a regulator then, probably?

[...]

> +	wcd_default: wcd-reset-n-active-state {
> +		pins = "gpio108";
> +		function = "gpio";
> +		drive-strength = <16>;
> +		bias-disable;
> +		output-low;

no need for this property

> +	};
> +
> +	fan_pwr_active: fan-pwr-active-state {
> +		pins = "gpio109";
> +		function = "gpio";
> +		drive-strength = <2>;
> +		bias-disable;
> +		output-low;

likewise, especially since it's the opposite of the active state
defined in the vreg node

[...]

> +	usb0_sbu_default: usb0-sbu-state {
> +		oe-n-pins {
> +			pins = "gpio140";
> +			function = "gpio";
> +			bias-disable;
> +			drive-strength = <16>;
> +			output-high;

This is probably not required too.. unless there's a hw bug?

fwiw 16 mA is a very high drive-strength - does this come from vendor
sources?

Konrad