Re: [PATCH 5/5] sched/fair: Make asym CPU capacity idle rank values self-documenting

[Vincent Guittot]

On Fri, 24 Apr 2026 at 07:19, Andrea Righi <arighi@xxxxxxxxxx> wrote:
>
> Hi Prateek,
>
> On Fri, Apr 24, 2026 at 09:59:42AM +0530, K Prateek Nayak wrote:
> > Hello Andrea,
> >
> > On 4/23/2026 1:06 PM, Andrea Righi wrote:
> > > From: K Prateek Nayak <kprateek.nayak@xxxxxxx>
> > >
> > > Introduce enum asym_fits_state for select_idle_capacity() scan
> > > preferences, instead of using raw constants to improve readability.
> > >
> > > No functional change.
> > >
> > > Signed-off-by: K Prateek Nayak <kprateek.nayak@xxxxxxx>
> >
> > All I did was suggest an enum; You did all the work on this :-)
>
> Well, actually you wrote the code, I wrote the patch description. :)
>
> > I think this can be squashed into Patch 3 and that way we have we
> > can avoid the magic numbers from the get-go. Thoughts?
>
> Yeah, that's probably better, no reason to have a separate patch. I'll do that
> in the next version.

I agree that this should be merged with patch 2

>
> Thanks,
> -Andrea