Re: [PATCH] staging: rtl8723bs: add spaces arround |

[Luka Gejak]

On Thu Apr 23, 2026 at 10:12 PM CEST, Henrique Cazarim wrote:

Hi Henrique,
thanks for the patch, few notes below.

>     Fix checkpatch error "CHECK: spaces preferred around that '|'"
>     in rtw_ioctl_set.c:154.

What is this indentation, it shouldn't be there especially not with 
spaces. Also same in subject "[PATCH]     staging:" is wrong. There 
should be only one space between [PATCH] and staging, so: 
"[PATCH] staging:". One more thing regarding the subject, it should be 
more descriptive of actual change. "add spaces arround |" doesn't give 
any additional information. You should at least say what is change 
affecting or where is the change located. Something like: "add spaces 
arround | in rtw_set_802_11_ssid".

>
> Signed-off-by: Henrique Cazarim <hcazarim@xxxxxxxxx>
> ---
>
 ^^^^^
Also you have unnecessary blank line above.

> Hey, this is my first patch, I appreciate any feedback, thanks!
> ---
>  drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> index c70541f95a73..edfb4b5e8db0 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> @@ -151,7 +151,7 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, struct ndis_802_11_ssid *ssid)
>  	else if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING) == true)
>  		goto release_mlme_lock;
>  
> -	if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) == true) {
> +	if (check_fwstate(pmlmepriv, _FW_LINKED | WIFI_ADHOC_MASTER_STATE) == true) {
>  		if ((pmlmepriv->assoc_ssid.ssid_length == ssid->ssid_length) &&
>  		    (!memcmp(&pmlmepriv->assoc_ssid.ssid, ssid->ssid, ssid->ssid_length))) {
>  			if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) == false) {

Please send v2 with mentioned changes, code itself it good and should be
left as is.
Best regards,
Luka Gejak