Re: [PATCH] hwmon: (corsair-psu) Close HID device on probe errors

[Wilken Gottwalt]

On Fri, 24 Apr 2026 22:50:51 +0900
Myeonghun Pak <mhun512@xxxxxxxxx> wrote:

> corsairpsu_probe() opens the HID device before sending the device init
> and firmware-info commands. If either command fails, the error path jumps
> directly to fail_and_stop and skips hid_hw_close().
> 
> Use the existing fail_and_close label for those post-open failures so the
> open count and low-level close callback are balanced before hid_hw_stop().
> 
> Fixes: d115b51e0e56 ("hwmon: add Corsair PSU HID controller driver")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Myeonghun Pak <mhun512@xxxxxxxxx>
> ---
>  drivers/hwmon/corsair-psu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/corsair-psu.c b/drivers/hwmon/corsair-psu.c
> index dddbd2463f..76f3e1da68 100644
> --- a/drivers/hwmon/corsair-psu.c
> +++ b/drivers/hwmon/corsair-psu.c
> @@ -796,13 +796,13 @@ static int corsairpsu_probe(struct hid_device *hdev, const struct
> hid_device_id ret = corsairpsu_init(priv);
>  	if (ret < 0) {
>  		dev_err(&hdev->dev, "unable to initialize device (%d)\n", ret);
> -		goto fail_and_stop;
> +		goto fail_and_close;
>  	}
>  
>  	ret = corsairpsu_fwinfo(priv);
>  	if (ret < 0) {
>  		dev_err(&hdev->dev, "unable to query firmware (%d)\n", ret);
> -		goto fail_and_stop;
> +		goto fail_and_close;
>  	}
>  
>  	corsairpsu_get_criticals(priv);

I really had to go back to the initial commit to check, if I introduced that
issue later. But nope, I had it that way from the start. Good catch, I totally
missed that. Thank you.

greetings,
Wilken

Reviewed-by: Wilken Gottwalt <wilken.gottwalt@xxxxxxxxxx>