Re: [PATCH] tty: serial: samsung: add dedicated compatible for exynosauto SoCs
From: Krzysztof Kozlowski
Date: Fri Apr 24 2026 - 12:12:28 EST
On 24/04/2026 12:18, Alim Akhtar wrote:
> Currently Exynosautov-{9,920} getting probed based on exynos850
> fallback. It is recommended to have a dedicated compatible for
> proper driver binding.
Unfortunately it is not. Dedicated compatible you have. However you are
not adding dedicated compatible. You added dedicated driver match entry
and we, and especially me, gave reviews many times that it is *not
recommended* to have dedicated driver match entry.
Entire reasoning for doing this patch is wrong. And patch itself is NOOP
(at least by quick look).
Best regards,
Krzysztof